Question Joomla 6 support?

Good you already started to test.
When updating an old extension of mine to J6 I also ran into white pages: no error even with php set to report everything to maximum level.
Turned out to be an issue with a check if a class existed > that got auto loaded to be able to determine and in the loaded class was a Joomla constant that didn't exist any more. No error thrown as class_exist doesn't throw errors, just false when the class is not present or true when it is.

Took me a lot of debugging to get to the root cause of that.

mentioning this here (not related) to stipulate that upgrading to J6 might not be as straight forward as just replacing some deprecated code.

After the holidays i will spend some time testing: maybe a good idea to chop up the work needed so we can work in parallel on this.

And as a side note: maybe also a good moment to get the code style figured out: currently when somebody does a change, it is difficult to see what actually changed as almost every line is impacted due to tabs / spaces / etc. I think it is also good to agree on a guideline on this: would for sure make at least my life easier

Hello,

I have looked if there are class_exist usage, there are, but it check on Kunena classes not Joomla! ones.

I had made some others tests yerstayday, i have tried to comment plenty part of code in the file github.com/Kunena/Kunena-Forum/blob/K6.5/src/script.php but each time i have encountered a white page. Then because it's a package i have tried to install all part (plugins, components...) separatly. I have just found an issue in the plugins system of Kunena. $this->app is null now here github.com/Kunena/Kunena-Forum/blob/K6.4...nena/kunena.php#L122 , by commenting all the content of function of onAfterInitialise() it works by installing this plugin alone but updating it in the package of Kunena i still get a white page on install. I haven't tried both.

Hello,

For the install script by looking in the manual it's not the right way : manual.joomla.org/docs/next/building-ext...ion/install-process/

By using a clean sample like gived in the manual, i do'nt have a white page during the install. I need to reimplement of the features of the older script. How to get the manisfest data now ?
I have still whites pages on Kunena dashboard, categories manager...

I have created a 6.5 project on github repo, empty for now, do-you want an access to it ?

xillibit wrote:

Hello,

I have just found an issue in the plugins system of Kunena. $this->app is null now here github.com/Kunena/Kunena-Forum/blob/K6.4...nena/kunena.php#L122 , by commenting all the content of function of onAfterInitialise() it works by installing this plugin alone but updating it in the package of Kunena i still get a white page on install. I haven't tried both.The plugins should be refactored into subscriber plugins. $this app will not work anymore as that is something automatically set from the extended class.
When implementing the subscriber interface you can use $this->getApplication().

But note: when refeactoring the plugins, they will receive actual events, so the functions themselves als need to be refactored to use these methods.

And when doing Kunena own triggered events, then these should also implement real event classes (Kunena can have their own).

Let me refactor the system plugin for you next week. My last week before my holidays. Will be back half way august and can then spend some more time.

There is already a 6.5 branch? I did a PR against that for the captcha triggering?
 

xillibit wrote:

Hello,

For the install script by looking in the manual it's not the right way : manual.joomla.org/docs/next/building-ext...ion/install-process/

By using a clean sample like gived in the manual, i do'nt have a white page during the install. I need to reimplement of the features of the older script. How to get the manisfest data now ?
I have still whites pages on Kunena dashboard, categories manager...

I have created a 6.5 project on github repo, empty for now, do-you want an access to it ?


 

That depends on what you need from the manifest.
Joomla itself has an installer script class that you can use (currently not able to check what the name / location is).
Or you can have a look at the installer helper I use in my extensions: it has all the methods I ever needed.

Hello,

Yes the 6.5 branch exists : github.com/Kunena/Kunena-Forum/tree/K6.5 . Yes your PR about captcha was done against 6.5 branch : github.com/Kunena/Kunena-Forum/pull/9888

Ok i let you work on system plugin

ruud wrote:

That depends on what you need from the manifest.
Joomla itself has an installer script class that you can use (currently not able to check what the name / location is).
Or you can have a look at the installer helper I use in my extensions: it has all the methods I ever needed.


 

It's to just retrieve the version of Kunena to be installed for the requirements checks

The manual say the script needs to use libraries/src/Installer/InstallerScriptInterface.php actually the class acutally in script extends InstallerScript or the other method is to use a Dependency Injection Container

P.S. : i have just seen that i forgot to copy some lines which defines the versions allowed, now the check of requirements works