Question set image size in posting not working (reason for my former problem)

one step beyond:

the main problem is the very basic bbcode plugin
(somewhere I read it is just a kind of skeleton and must be edited for full/own use)

1. this is the part where the properties dialog is cut out

 

now the next step is to find out how to send the properties to the bbcode
and
where this attributes must be set to be allowed so the editor will fully work

the important thing is that it looks like all depends on the bbcode plugin, nowhere else

I upload the plugin.js is someone can/wants  help
as I'm not so good in RegEx Expressions: can someone check this line from the code, as my program marks an error here
 

I have just tried but i can't anymore add new issues on ckeditor 4 :  github.com/ckeditor/ckeditor4/issues

There is a version 3.2.1 of SCeditor and i have updated it in developpement branch :  github.com/Kunena/Kunena-Forum/commit/e1...2451928c95f256e08f0f

joomod wrote:

any thoughts about switching to the new CKEditor 5 ?







 

Hello,

Yes, it's a possibility but because CKeditor 5 uses markdown and not support bbcode there should be a way to convert bbcode to markdown. I haven't looked at this actually.

joomod wrote:

one step beyond:

the main problem is the very basic bbcode plugin
(somewhere I read it is just a kind of skeleton and must be edited for full/own use)




 

In the demo it works : ckeditor.com/docs/ckeditor4/latest/examples/image.html , so it's probably the bbcode plugin which disable it when used

joomod wrote:

I upload the plugin.js is someone can/wants  help
as I'm not so good in RegEx Expressions: can someone check this line from the code, as my program marks an error here

Code:

bbcPartsRegex: /(?:\[([^\/\]=]*?)(?:=([^\]]*?))?\])|(?:\[\/([a-z]{1,16})\])/ig

 

File Attachment:

File Name: bbcode-plugin.zip
File Size:7.59 KB

 

I don't understand why you want change this regex

When looking the  plugins/bbcode/plugin.js, there are two part where img is handled :

• github.com/ckeditor/ckeditor4/blob/maste...bcode/plugin.js#L611
• github.com/ckeditor/ckeditor4/blob/maste...bcode/plugin.js#L719

So i think it's more into this others areas
 

I don't understand why you want change this regex

because of the 2nd problem.
1. is the missing "translation" of image properties to bbcode
2. error when opening CKeditor if img has some attributes added within the tag using whitespace.
(disabling the bbcode does open the editor as it should be, so there must be a problem within bbcode)

for the first I'm ready with the insertation, but as there is the 2nd bug I cannot
test if the bbcode is correctly read and translated to html.

also I'm not shure if the CK bbcode plugin basicly will work with all the special addons like ebay, video etc.

In the demo it works : ckeditor.com/docs/ckeditor4/latest/examples/image.html , so it's probably the bbcode plugin which disable it when used 

that's correct. the original bbcode plugin disables the properties settings of images (see "tab.remove('basic') in the screenshot,
mainly because the there is no implenentation of properties to the bbcode or
the main problem, as each addition (style=  or direct width=) will be added using whitespace in the img tag, which causes problems.

In the moment I have done this:
in the ckeditor_config.js 
config.removePlugins = 'bbcode';  //disable the original bbcode plugin, because included in the big minified file
config.extraPlugins = 'bbcode2';  //just renaming the standalone bbcode to bbcode2, so I can easily edit it 

1st steps:
disabling the remove of properties dialog (see screenshot)
adding properties inclusion

I attach the bbcode2 plugin without any edition, (only the neccearry renaming to bbcode2 in the .add comand line 558) 
- also I packed the plugin-edited.js version with my first test correction for imgsize

basicly I found this statement to the original bbcode plugin.js

The BBCode plugin is more of a showcase plugin which presents how to make your own implementation for bbcode. This is not a full bbcode implementation but more of a jump start code. This plugin doesn't support width for images and it is a user responsibility to add it.

 

There is a version 3.2.1 of SCeditor and i have updated it in developpement branch :  github.com/Kunena/Kunena-Forum/commit/e1...2451928c95f256e08f0f

that's fine - I will look if there are important changes.
Nevertheless, as SCEditor generates a width x height property there is the  need to change the lKunenaBBCode.php
to allow the 'x' letter  (allow /^\d*x\d*$  line 728), otherwise Kunena would ignore it
(also the change to attribute 'size=' would be useful, so SCEditor could read old message styles)

I have digged a bit by working on the unminified version of bbcode plugin :

on line 31, i have changed it and added the width and height attibutes : 

To use it you need to have that in the message column #__kunena_messages_text 

 

It's not keeped when you create/edit your message 

joomod wrote:

There is a version 3.2.1 of SCeditor and i have updated it in developpement branch :  github.com/Kunena/Kunena-Forum/commit/e1...2451928c95f256e08f0f

that's fine - I will look if there are important changes.
Nevertheless, as SCEditor generates a width x height property there is the  need to change the lKunenaBBCode.php
to allow the 'x' letter  (allow /^\d*x\d*$  line 728), otherwise Kunena would ignore it
(also the change to attribute 'size=' would be useful, so SCEditor could read old message styles)

I had made a Pull Request with your cahnges on this : github.com/Kunena/Kunena-Forum/pull/10051 . I'am waiting your feedback on this

your result looks quite good, as it comes in the same format as basicly SCEditor returns,
and of course it should work and be opened in the CKEditor,
but my main intent was to find a solution, which will open old Kunena posts as well which uses the
img size=xxx attribute 

btw.   feel free to publish my SCEditor changes in the pull request, as I'm not so confirmed with github