Question Avatar size exceed limit allowed by configuration

Hi,

indeed, I have the same issue and followed Kallehak's steps and it seems to be OK, so far.

However, I do not understand why this worked in 5.0.14, where the code in this respect is identical....:dry:

unker wrote: However, I do not understand why this worked in 5.0.14, where the code in this respect is identical....:dry:

I don't know, that sounds to me like the actual problem is somewhere else.

With the update to 5.1.1, nothing changed for me sadly

Kallehak wrote: I checked libraries/kuena/upload/upload.php and found that the functions:

checkFileSizeAvatar
checkFileSizeFileAttachment
checkFileSizeImageAttachment

did return 0 when a file/image were not bigger than allowed. So I changed:

return (int) max(
0,
min(
$this->toBytes(ini_get('upload_max_filesize')) - 1024,
$this->toBytes(ini_get('post_max_size')) - 1024,
$this->toBytes(ini_get('memory_limit')) - 1024 * 1024
)
);

to:

return true;

in the functions and now it works

With that you can never check if the avatar size exceed the limits set in configuration

Yes, xillibit,

you are absolutely right.

So we have the choice:
no avatars, attachments and images
or
no size control...

...as long as nothing will be corrected

Best Regards
Hartmut

xillibit wrote:

Kallehak wrote: [...]
in the functions and now it works

With that you can never check if the avatar size exceed the limits set in configuration

Actually the check are made. The function returns FALSE if the size exceeds the limit set in configuration. Problem was/is that the function returns 0 which is the same as false when the size did not exceed the limit. Looks like this return code is not in use anymore as originally intended I suppose.