Solved sceditor update pack

there are 3 steps needed
1. upload the plugin to the standard sceditor folder
2. load the plugin in the template layouts/widget/editor/sceditor.php
3. add the plugin in the template assets/js/sceditor.js sceditor create command


btw.
there (hopefully) will come more updates for sceditor, because als map is totally useless

 

I had put the undo.js file under a plugins directory so i have fixed it in my Pull Request , now the undo.js is loaded when i look the source code of the page and the CSS copied had some errors, i have fixed it too. It still displays like on my image above, i need to check all the changes

btw in your changes related to teh poll, you have put an alert :

To show the message to the user you shouldn't use an alert from javascript but display it by using boostrap alert instead :  getbootstrap.com/docs/4.0/components/alerts/

By adding your changes in TemplateController and saving template params it's better : 

 

if you don't like the left side buttons (as rich20 shows on github) you just have to 
uncommand 2nd rule (#kunena.layout ....:lastChild)   (and 3rd to skip the so no longer needed margin).

in your picture it looks like the margin for #myTab, #myTabContent (Nr. 3) should be greater so the buttons stays inside the outer border

btw. have you intentionally disabled the quote button?  or have you missed to replace 'blockquote' -> $editorButtons = 'quote'; in the TemplateController
edit: I  see on github:(line 472)  you haven't delete the negation from ( !$params ) (blockquote is the param used in config, not quote)
(I also don't see table and horizontalrule, but this may be your setting?)

also have a look at the problem of rich20 with the Kunena icons,  so just use the new famfamfam.png and new default.css,
but in the main (or general?).scss of the template the icon lines for the buttons must be disabled.

the javascript alert was just a quick idea (don't know if you will keep it), so no problem to change to bootstrap 

joomod wrote:

btw. have you intentionally disabled the quote button?  or have you missed to replace 'blockquote' -> $editorButtons = 'quote'; in the TemplateController
edit: I  see on github:(line 472)  you haven't delete the negation from ( !$params ) (blockquote is the param used in config, not quote)
(I also don't see table and horizontalrule, but this may be your setting?)



 

Hello,

No it wasn't my intention. I have copied the entire SaveSCeditorParamFile() method from your file, so i will remove the ! for blockquote
For table and horizontalrule it has been removed from CKeditor because not very much used so in SCeditor it should be the same

joomod wrote:

also have a look at the problem of rich20 with the Kunena icons,  so just use the new famfamfam.png and new default.css,
but in the main (or general?).scss of the template the icon lines for the buttons must be disabled.

the javascript alert was just a quick idea (don't know if you will keep it), so no problem to change to bootstrap 

Just applied your changes for the issue reported by rich : github.com/Kunena/Kunena-Forum/commit/c2...66e5c9c15f4967410283

I wanted to add your changes on TemplateController in backned in this PR : github.com/Kunena/Kunena-Forum/pull/10108 (changes was starting from this line : github.com/xillibit/Kunena-forum/blob/0e...eController.php#L329 ), i have reverted the changes on this file because i have seen some errors in the php log

• Warning:  Undefined array key "Cut" in C:\Users\xiilibit\git\Kunena-forum-K7.0-fork\src\admin\src\Controller\TemplateController.php on line 331
• Warning:  Undefined array key "Copy" in C:\Users\xillibit\git\Kunena-forum-K7.0-fork\src\admin\src\Controller\TemplateController.php on line 335
• Warning:  Undefined array key "Paste" in C:\Users\xillibit\git\Kunena-forum-K7.0-fork\src\admin\src\Controller\TemplateController.php on line 339
• Warning:  Undefined array key "Source" in C:\Users\xillibit\git\Kunena-forum-K7.0-fork\src\admin\src\Controller\TemplateController.php on line 347
• Warning:  Undefined array key "Table" in C:\Users\xillibit\git\Kunena-forum-K7.0-fork\src\admin\src\Controller\TemplateController.php on line 351
• Warning:  Undefined array key "Quote" in C:\Users\xillibit\git\Kunena-forum-K7.0-fork\src\admin\src\Controller\TemplateController.php on line 355

Can-you provide a fix for that ?