Solved sceditor update pack

No it wasn't my intention. I have copied the entire SaveSCeditorParamFile() method from your file, so i will remove the ! for blockquote
For table and horizontalrule it has been removed from CKeditor because not very much used so in SCeditor it should be the same

sorry, I see it was an error in my file

Just applied your changes for the issue reported by rich : github.com/Kunena/Kunena-Forum/commit/c2...66e5c9c15f4967410283

as far as I see, you have added the new famfamfam.png, but not the new css code for those kunena icons in the default.css
(the only change I see is the cutout my left-side buttons option, but not the new position definitions for the icons)

Can-you provide a fix for that ?

I don't see the reason for this errors, (I don't have them) - 
the array keys are not new, only the strings in $editorButtons[] have changed a bit (mostly lowercase)
I just looked at the github file and mine, and the only difference are the new additions what I have added for CKEditor,
so I just deleted them and now the line numbering corresponds each other, so they should be identical (beside the string changes)

check the new file
 

 

joomod wrote:

Can-you provide a fix for that ?

I don't see the reason for this errors, (I don't have them) - 
the array keys are not new, only the strings in $editorButtons have changed a bit (mostly lowercase)
I just looked at the github file and mine, and the only difference are the new additions what I have added for CKEditor,
so I just deleted them and now the line numbering corresponds each other, so they should be identical (beside the string changes)

check the new file
 

File Attachment:

File Name: TemplateCo...ller.zip
File Size:4 KB

I have tested your new file but it's the same.
In fact these errors are coming because (Cut, Copy...) are not defined in the config.xml

joomod wrote:

Just applied your changes for the issue reported by rich : github.com/Kunena/Kunena-Forum/commit/c2...66e5c9c15f4967410283

as far as I see, you have added the new famfamfam.png, but not the new css code for those kunena icons in the default.css
(the only change I see is the cutout my left-side buttons option, but not the new position definitions for the icons)




 

I have removed the bits for undo which will be in a new PR and i had found weird that there is some space left on the right :

 

In fact these errors are coming because (Cut, Copy...) are not defined in the config.xml

you are right, these are not defined in config,  but they come from your orig. TemplateController,
I only changed to negation (because they are not in config and not selectable)

as there is no need here (these buttons are fix set in the template sceditor.js) you can simply delete it
(cut, copy, paste, source are fix - table you don't want - quote is old and replaced by blockquote)
but I wonder why I don't get this error, I only have the 'table' and horizontalrule add to my config

i had found weird that there is some space left on the right

I know what you mean, but there is nothing changed.
I couldn't figure out how sceditor is setting its width and the placement of buttons.
but in your setup is looks like you have no space bar in the last big group (before source)  so it is too big to be placed in the upper line

joomod wrote:

In fact these errors are coming because (Cut, Copy...) are not defined in the config.xml

you are right, these are not defined in config,  but they come from your orig. TemplateController,
I only changed to negation (because they are not in config and not selectable)

as there is no need here (these buttons are fix set in the template sceditor.js) you can simply delete it
(cut, copy, paste, source are fix - table you don't want - quote is old and replaced by blockquote)
but I wonder why I don't get this error, I only have the 'table' and horizontalrule add to my config

 

I have made some tests, in CKeditor the toolbar settings are in uppercase :
In SCeditor, the settings are in lowercase :
So that explains the errors in the php error log

Hello,

In the details of your changes to apply, why the poll setting should allow to display undo/redo here ?

P.S. : i have added your changes about undo and image parameters into the K7.1 branch, if you want take a look : github.com/Kunena/Kunena-Forum/tree/K7.1

In the details of your changes to apply, why the poll setting should allow to display undo/redo here ?

no, I just  took undo as button place where to display the poll button.
undo/redo is set fixed, so the replace method was an easy way to integrate the poll before the last group (if enabled)