×
Kunena 5.2.10.1 released (29 Sep 2022)

The Kunena team has announce the arrival of Kunena 5.2.10.1 [K 5.2.10.1] which is now available for download as a native Joomla extension for J! 3.10.x This version addresses most of the issues that were discovered in K 5.2 and issues discovered during the development stages of K 5.2.9

Solved H1 Titles in Kunena!

More
6 years 3 months ago #31 by sozzled
Replied by sozzled on topic H1 Titles in Kunena!

romagromov wrote: This is a BUG in stable version.

I agree with you and so, too, do others who have contributed to this discussion. The developers, on the other hand, seem to have as different view about K 4.0 as indicated in msg #24 above. Apparently (unless I have misunderstood what was written in msg #24 above) there will be no bugfixes for K 4.0. But, we can wait to see if there's been a change of heart. As I understand the message, if you use K 4.0—the current stable version—you have to live with it as it is. Sorry.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago - 6 years 3 months ago #32 by romagromov
Replied by romagromov on topic H1 Titles in Kunena!
Ok, I trying to fix it.
But Kunena have very tangled code.

I found, that Blue Eagle template generates Meta Description and Keywords from this file:

/components/com_kunena/views/topic/view.html.php


Crypsis get Meta Description and Keywords from here

/components/com_kunena/controller/topic/item/display.php

Line 149

code
$this->headerText = JText::_('COM_KUNENA_TOPIC') . ' ' . html_entity_decode($this->topic->displayField('subject'));

UPD.

I got it!

I need some time to fix it.

Download Free Software for Windows absolutly free.
Last edit: 6 years 3 months ago by romagromov.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago - 6 years 3 months ago #33 by romagromov
Replied by romagromov on topic H1 Titles in Kunena!
Fix of Meta Description and Meta Keywords for Crypsis template

Open file /components/com_kunena/controller/topic/item/display.php

Found code in line 374
$this->setKeywords($headerText);

replace with
$this->setKeywords($this->topic->subject.', '.$this->category->name.', '.$this->category->getParent()->name.', '.$this->config->board_title);


Found code in line 384
$this->setDescription($description);

replace with
$description = KunenaHtmlParser::stripBBCode($this->topic->first_post_message, 182);
$description = preg_replace('/\s+/', ' ', $description); // remove newlines
$description = trim($description); // Remove trailing spaces and beginning
$page = $this->pagination->pagesCurrent;
$total = $this->pagination->pagesTotal;
$page = ($total > 1 ? " ({$page}/{$total})" : '');
$this->setDescription($description.$page);

File in attachment. File renamed in .txt - this forum do not able to upload php files.
Rename it with display.php

Meta tags will displays as in Blue Eagle template. Of course after update changes will be lost.

Also I fixed H1, H2 headers in Crypsis.

Now Topic, Category and Forum Title use H1.
Topics in Category use H2.
Also removed link from H1.

Attached too.

Download Free Software for Windows absolutly free.
Attachments:
Last edit: 6 years 3 months ago by romagromov.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago #34 by 810
Replied by 810 on topic H1 Titles in Kunena!
@romagromov
you not allowed to use H1 H2 ect in tables.


Thats why it isn't easy to change the code.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago - 6 years 3 months ago #35 by romagromov
Replied by romagromov on topic H1 Titles in Kunena!
H1 is not inside tables.
Who forbids the use of H2 in tables?

Let us assume that this is so.
Why you use tables???
It's too old layout method.
Now we should use divs or ul lists.

Anyway, I fixed meta tags. Hope you'll add it in package.

Download Free Software for Windows absolutly free.
Last edit: 6 years 3 months ago by romagromov.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago #36 by 810
Replied by 810 on topic H1 Titles in Kunena!
when you will do a W3C Validation check, then you will be warned to change this code.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago - 6 years 3 months ago #37 by romagromov
Replied by romagromov on topic H1 Titles in Kunena!
Even if it were so, It much better to have H1 and H2 with wrong html markup, than not to have H1, H2 at all. ;)

I also want to notice, that wrong html markup does not affect on ranking.

I have checked category page, in which all topics have H2 in table.
No any warnings about that.


Download Free Software for Windows absolutly free.
Last edit: 6 years 3 months ago by romagromov.
The following user(s) said Thank You: ChaosHead

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago #38 by Josh
Replied by Josh on topic H1 Titles in Kunena!

810 wrote: For the H1, i will add a template option


I don't see this option in RC3. Perhaps I'm missing something?

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago #39 by 810
Replied by 810 on topic H1 Titles in Kunena!
still looking for the right solution.

its not correct to have H in the tables.

Please Log in or Create an account to join the conversation.

More
6 years 3 months ago - 6 years 3 months ago #40 by Josh
Replied by Josh on topic H1 Titles in Kunena!
I agree. However I don't understand why it would be inside of a table in the first place. You can see that the H3 DOM element is not placed in a table:

Attachments:
Last edit: 6 years 3 months ago by Josh.

Please Log in or Create an account to join the conversation.

  • Not Allowed: to create new topic.
  • Not Allowed: to reply.
  • Not Allowed: to edit your message.
Time to create page: 0.103 seconds