Solved Can't delete private part of topic messages

Hello,

I tried to remove the private part of a message of a user via the frontend edit function. 
However every time I deleted everything and saved, the text stayed the same. If I just changed a bit, it was saved.
After some debugging I found out that this behaviour is by design:
In the file  github.com/Kunena/Kunena-Forum/blob/eb61.../TopicController.php
Starting with line 1588 in the editPrivate-function I found that there's just a return if the body is empty:
Shouldn't the expected behaviour be, that the private part of the message is deleted instead of just aborting the edit of the private message?
Or is there any other way to remove the private part I don't know of?

Thanks in advance for your answers!

Marco
 

Hello,

Thanks for the feedback.

This change was intented see issue :  github.com/Kunena/Kunena-Forum/issues/9880 , if you have private part empty and normal text part empty it cause some errors.

In your case you had the normal text part empty ?

Hello,

I have just made a change for it, you can try the change :  github.com/Kunena/Kunena-Forum/pull/10031

Hello,

thanks for your fast answer and pull request.
You are right, I have a public part and just want to delete the private part of the message.

If I just change the if in line 1588 like you provided, the message automatically fallbacks to "No private message has been set, only private attachments" because of line 1612: 
Also even if I would unset the $private->body there, in line 1621 would still not be true because even if I don't have private attachments, I still have an array $attachIds with 0 = "" which results in $private->attachments being 1.

However if I quickly try to unset both, $private->body and $private->attachments, the private part is deleted as I would expect.
I don't have a Github account at work but I try to find the time to do some more debugging in private and will then answer your pull request.

Thanks again for your help.

Hello,

I will later today to improve my PR, this message in private part is useless is you have something in the normal message part

Hello,

I have made an another Pull Request  with others changes :  github.com/Kunena/Kunena-Forum/pull/10032