Kunena 7.0.2 Released

The Kunena team has announce the arrival of Kunena 7.0.2 [K 7.0.2] in stable which is now available for download as a native Joomla extension for J! 5.3.x/5.4.x/6.0.x. This version addresses most of the issues that were discovered in K 6.2 / K 6.3 / K 6.4 and issues discovered during the last development stages of K 7.0

Question Bug: Configuration 'User Edits - Yes, except no replies' not working properly

More
8 years 2 months ago #197345 by WolfgangOWL
Bug: Configuration 'User Edits - Yes, except no replies' not working properly was created by WolfgangOWL
I'm on Kunena 5.0.12 and the configuration option 'User Edits - Yes, except no replies' does not work as expected.

It does only affect the delete-button. In my humble opinion this should also hide the edit-button when the option is set. At least I would expect this behaviour since the option suggests that. I'm pretty sure this worked correctly in the past. I don't know in which Kunena version the behaviour changed.

Do you have a patch for me?

I wish everyone a merry Christmas,
Wolfgang
www.scrollsawprojects.net

Please Log in or Create an account to join the conversation.

More
8 years 2 months ago #197346 by rich
Replied by rich on topic Bug: Configuration 'User Edits - Yes, except no replies' not working properly
Yes you're right, it does not work anymore. But for me it was also a bug before. It makes no sense, to edit a previously message, when already a answer exist.

Please correct me if I'm wrong: The text "Yes, except no replies" means grammatically, the user can always edit, it's only forbidden, if still nobody has answered. And exactly so has worked this option in previously versions.

It should be:
User Edits - Yes, when no replies

Can you confirm this?
Important! Always create a backup before you make any changes to your website!

Please Log in or Create an account to join the conversation.

More
8 years 2 months ago #197348 by WolfgangOWL
Replied by WolfgangOWL on topic Bug: Configuration 'User Edits - Yes, except no replies' not working properly
Hi Rich,

yes, you are right. The option should be named 'Yes, when no replies' or 'Yes, except when replies'. I didn't think about this because it makes absolutely no sense the other way round.
www.scrollsawprojects.net

Please Log in or Create an account to join the conversation.

More
8 years 2 months ago #197350 by rich
Replied by rich on topic Bug: Configuration 'User Edits - Yes, except no replies' not working properly
Thank you for the confirmation Wolfgang!

I will create a ticket on Git.
Important! Always create a backup before you make any changes to your website!
The following user(s) said Thank You: WolfgangOWL

Please Log in or Create an account to join the conversation.

More
8 years 2 months ago #197394 by WolfgangOWL
Replied by WolfgangOWL on topic Bug: Configuration 'User Edits - Yes, except no replies' not working properly
Hello Rich,

I saw at Git that 810 added a commit for this bug. He made a change in line 1646 in libraries/kunena/forum/message/message.php.

Unfortunately, this change is not working correctly.
Code:
if (intval($config->useredit) == 2 && $this->getTopic()->getReplies())

This means if there is any reply within a topic a user can't edit his own post, even if the last post is his own.

The following change should fix it:
Code:
if (intval($config->useredit) == 2 && $this->getTopic()->getReplies() && $this->getTopic()->last_post_id > $this->id)

Could you possibly contact 810 to check.

Thank you,
Wolfgang
www.scrollsawprojects.net
The following user(s) said Thank You: rich

Please Log in or Create an account to join the conversation.

More
8 years 2 months ago - 8 years 2 months ago #197396 by rich
Replied by rich on topic Bug: Configuration 'User Edits - Yes, except no replies' not working properly
Hello Wolfgang,

Thanks for the hint! I've noticed this mistake before read this message and created a new ticket, because this problem now also exists at the Option "User can delete when no replies". github.com/Kunena/Kunena-Forum/issues/5688
But I've now 810 made aware of your contribution.
Important! Always create a backup before you make any changes to your website!
Last edit: 8 years 2 months ago by rich.
The following user(s) said Thank You: WolfgangOWL

Please Log in or Create an account to join the conversation.

Time to create page: 0.271 seconds