- Posts: 340
- Thank you received: 36
Kunena 6.3.0 released
The Kunena team has announce the arrival of Kunena 6.3.0 [K 6.3.0] in stable which is now available for download as a native Joomla extension for J! 4.4.x/5.0.x/5.1.x. This version addresses most of the issues that were discovered in K 6.2 and issues discovered during the last development stages of K 6.3
Question Duplicate warning when user is not authorised to view attachment
8 years 6 months ago #1
by Pinkeltje
When applying this setting:
And same for files, a duplicate warning appears in topic when user is not logged in:
Blue Eagle and Crypis.
A search on language constante shows that
is in following files:
Maybe this helps to track the problem.
To make sure it didn't have anything to do with settings or template, I made a fresh Kunena 4.0.6 install on localhost using Blue Eagle and default Protostar template.
And same for files, a duplicate warning appears in topic when user is not logged in:
Blue Eagle and Crypis.
A search on language constante shows that
Code:
COM_KUNENA_SHOWIMGFORGUEST_HIDEIMG
/libraries/kunena/bbcode/bbcode.php
/libraries/kunena/attachment/attachment.php
Maybe this helps to track the problem.
To make sure it didn't have anything to do with settings or template, I made a fresh Kunena 4.0.6 install on localhost using Blue Eagle and default Protostar template.
Please Log in or Create an account to join the conversation.
8 years 5 months ago - 8 years 5 months ago #2
by juliank92
Replied by juliank92 on topic Duplicate warning when user is not authorised to view attachment
Hi Pinkeltje,
I don't know why the Kunena team has chosen to display multiple messages? If you would ask me, i should say it should be enough if there is only one notification. (Let's say the blue one, but hey that is my and probably a different kind of logic)
The red colored notifications, where generated when there should be a attached image displayed by the BB tags. So in this case you should be looking in the file /libraries/kunena/bbcode/bbcode.php, there is a method/function there called renderAttachment on line 2212, you could replace it with the following:
Basically i just added a condition, you should get the same the same if you replace the return null within this condition:
(But just to be safe i added a additional condition, since i don't know when the isAutorised method is false 
)
I don't know why the Kunena team has chosen to display multiple messages? If you would ask me, i should say it should be enough if there is only one notification. (Let's say the blue one, but hey that is my and probably a different kind of logic)
The red colored notifications, where generated when there should be a attached image displayed by the BB tags. So in this case you should be looking in the file /libraries/kunena/bbcode/bbcode.php, there is a method/function there called renderAttachment on line 2212, you could replace it with the following:
Code:
protected function renderAttachment(KunenaAttachment $attachment, $bbcode, $displayImage = true)
{
$layout = KunenaLayout::factory('BBCode/Attachment')
->set('attachment', $attachment)
->set('canLink', $bbcode->autolink_disable == 0);
$config = KunenaConfig::getInstance();
if (!$attachment->exists() || !$attachment->getPath())
{
return (string) $layout->setLayout('deleted');
}
elseif (!$attachment->isAuthorised() && !$config->showimgforguest)
{
return null;
}
elseif (!$attachment->isAuthorised())
{
return (string) $layout->setLayout('unauthorised');
}
$bbcode->parent->inline_attachments[$attachment->id] = $attachment;
if ($displayImage && $attachment->isImage())
{
$layout->setLayout('image');
}
return (string) $layout;
}
Basically i just added a condition, you should get the same the same if you replace the return null within this condition:
Code:
elseif (!$attachment->isAuthorised())
{
return (string) $layout->setLayout('unauthorised');
}
)
Last edit: 8 years 5 months ago by juliank92.
Please Log in or Create an account to join the conversation.
8 years 5 months ago - 8 years 5 months ago #6
by Pinkeltje
Replied by Pinkeltje on topic Duplicate warning when user is not authorised to view attachment
As already mentionned in my first post: showing a message is ok, but there is no need to show a duplicate message.
Old situation:
After applying changes made by Juliank92:
Display for logged-in users (in both situations):
Old situation:
After applying changes made by Juliank92:
Display for logged-in users (in both situations):
Last edit: 8 years 5 months ago by Pinkeltje.
Please Log in or Create an account to join the conversation.
Time to create page: 0.553 seconds