Question Fixes, Suggestions and more

As spoken in this thread , there is an existing problem in template default_ex, if User put large images into their signature.

My solution is checked in validator and browser IE 6, IE 7, Firefox 3 and Opera 9 (i have no firefox 2)

---

I'll try to explain it, with my bad english

Put message and buttons in 1 td (not two), make two <div> with different classes and change a little bit the css. I have done so in template default_ex. The changed files are in attachment, give it a try.

change in message.php line 312 - 407

<table width="100%" cellpadding="0" cellspacing="0"><tr>
<?php
if ($msg_signature) {
echo '<td class="msgsignature"><div>';
echo $msg_signature;
echo '</div></td>';
}
?>
<td valign="bottom">
<div class="fb_message_buttons_cover">
<span id = "fb_qr_sc__<?php echo $msg_id;?>" class = "fb_qr_fire" style = "cursor:hand; cursor:pointer">

<?php
//we should only show the Quick Reply section to registered users. otherwise we are missing too much information!!
/* onClick="expandcontent(this, 'sc<?php echo $msg_id;?>')" */
if ($my->id > 0 && !$msg_closed)
{
?>

<?php echo
$fbIcons
? '<img src="' . KUNENA_URLICONSPATH . '' . $fbIcons . '" border="0" alt="' . _KUNENA_QUICKMSG . '" />' . '' : ' <img src="' . KUNENA_URLEMOTIONSPATH . 'quickmsg.gif" border="0" alt="' . _KUNENA_QUICKMSG . '" />'; ?>
<?php
}
?>
</span>

<?php
if ($fbIcons)
{
if ($msg_closed == "")
{
echo " " . $msg_reply;
echo " " . $msg_quote;

if ($is_Moderator) echo ' </div><div class="fb_message_buttons_cover">';

if ($msg_merge) {
echo " " . $msg_merge;
}

if ($msg_split) {
echo " " . $msg_split;
}
if ($msg_delete) {
echo " " . $msg_delete;
}
if ($msg_edit) {
echo " " . $msg_edit;
}

}
else {
echo $msg_closed;
}

}
else
{
if ($msg_closed == "")
{
echo $msg_reply;
?>

|

<?php
echo $msg_quote;

if ($msg_delete) {
echo " | " . $msg_delete;
}

if ($msg_move) {
echo " | " . $msg_move;
}

if ($msg_edit) {
echo " | " . $msg_edit;
}

if ($msg_sticky) {
echo " | " . $msg_sticky;
}

if ($msg_lock) {
echo "| " . $msg_lock;
}
}
else {
echo $msg_closed;
}
}
?>
</div>
</td></tr></table>

changed (is marked with red color if possible)

<table width="100%" cellpadding="0" cellspacing="0"><tr>
<?php
if ($msg_signature) {
echo '<td><div class="msgsignature"><div>';
echo '<div class="kunena_signature">';
echo $msg_signature;
echo '</div>';
echo '</div></div>';
}
?>
<div class="kunena_message_button">
<div class="fb_message_buttons_cover">
<span id = "fb_qr_sc__<?php echo $msg_id;?>" class = "fb_qr_fire" style = "cursor:hand; cursor:pointer">

<?php
//we should only show the Quick Reply section to registered users. otherwise we are missing too much information!!
/* onClick="expandcontent(this, 'sc<?php echo $msg_id;?>')" */
if ($my->id > 0 && !$msg_closed)
{
?>

<?php echo
$fbIcons
? '<img src="' . KUNENA_URLICONSPATH . '' . $fbIcons . '" border="0" alt="' . _KUNENA_QUICKMSG . '" />' . '' : ' <img src="' . KUNENA_URLEMOTIONSPATH . 'quickmsg.gif" border="0" alt="' . _KUNENA_QUICKMSG . '" />'; ?>
<?php
}
?>
</span>

<?php
if ($fbIcons)
{
if ($msg_closed == "")
{
echo " " . $msg_reply;
echo " " . $msg_quote;

if ($is_Moderator) echo ' </div><div class="fb_message_buttons_cover">';

if ($msg_merge) {
echo " " . $msg_merge;
}

if ($msg_split) {
echo " " . $msg_split;
}
if ($msg_delete) {
echo " " . $msg_delete;
}
if ($msg_edit) {
echo " " . $msg_edit;
}

}
else {
echo $msg_closed;
}

}
else
{
if ($msg_closed == "")
{
echo $msg_reply;
?>

|

<?php
echo $msg_quote;

if ($msg_delete) {
echo " | " . $msg_delete;
}

if ($msg_move) {
echo " | " . $msg_move;
}

if ($msg_edit) {
echo " | " . $msg_edit;
}

if ($msg_sticky) {
echo " | " . $msg_sticky;
}

if ($msg_lock) {
echo "| " . $msg_lock;
}
}
else {
echo $msg_closed;
}
}
?>
</div></div>
</td></tr></table>

And in kunena.forum.css delete or comment out with /* */ the text-align:right; in div.fb_message_buttons_cover and put some new code, (changes in red color)

div.fb_message_buttons_cover {
/*text-align:right; */
height: 15px;
line-height: 15px;
margin: 4px 0px 3px;
line-height: 14px;
white-space: nowrap;
}
#Kunena .kunena_message_button {
display: block;
margin-top: 10px;
margin-bottom:10px;
}
#Kunena .kunena_signature {
display: block;
padding-top: 10px;
padding-bottom:10px;
border-bottom: 1px solid #BFC3C6;
}

The changes you can see on screenshot ( i have taken the first image for signature, i have found in internet)

If you want to have the buttons below in one line you have to comment out or to delete this

echo ' </div><div class="fb_message_buttons_cover">';

In orginal message.php (from kunena) it is line 347

in my changed message.php it is line 349

<?php
if ($fbIcons)
{
if ($msg_closed == "")
{
echo " " . $msg_reply;
echo " " . $msg_quote;

if ($is_Moderator) /* echo ' </div><div class="fb_message_buttons_cover">';*/

if ($msg_merge) {
echo " " . $msg_merge;
}

In file attachment, is the message.php + forum.css (css is same as above) for getting the buttons below the signature and in one line, as shown on screenshot.

You find and have to change (before make backup of these files!) in components/com_kunena/template/default_ex

One user had buttonsm that were collapsed above in Internet Explorer 7. The template itself,that is used, has no clean code, but with this little change it works.




kunena.forum.css

changes (red)

#Kunena #Kunena_top td {
background: #FFFFFF;
color:#000000;
height:35px;
margin:0;
border-style:solid;
border-color:#5182A4;
border-top-width:0;
border-right-width:0;
border-bottom-width:3px;
border-left-width:0;
}

to new (red)

#Kunena #Kunena_top td {
background: #FFFFFF;
color:#000000;
height:auto;
margin:0;
border-style:solid;
border-color:#5182A4;
border-top-width:0;
border-right-width:0;
border-bottom-width:3px;
border-left-width:0;
}

About that last change: It may not work in IE6. IE6 has some issues with auto..

It has worked with IE 6, in this case, i had tested with different browser.
And you can check it here: www.airconservicing.com/discussions.html

This is with hight: auto


Perhaps generally a Browser switch (ie.css) or conditional comments to exklude IE 6 or something else.


Btw. I love IE :whistle: :blink:

Can you mix this fix and your Profile Positioning fix together? I've been trying to get them to work together, and it's just not.