Kunena 7.0.4 Released

The Kunena team has announce the arrival of Kunena 7.0.4 [K 7.0.4] in stable which is now available for download as a native Joomla extension for J! 5.4.x/6.0.x. This version addresses most of the issues that were discovered in K 6.2 / K 6.3 / K 6.4 and issues discovered during the last development stages of K 7.0

Topics that are moved into this category are generally considered to be closed. Users may want to add additional information but these topics should not be resurrected in order to discuss new problems or unrelated matters.

Question Bug (and fix): Quoting always shows realname, not username

More
14 years 7 months ago - 14 years 7 months ago #108006 by openglobal
Bug (and fix): Quoting always shows realname, not username was created by openglobal
I've discovered a bug in Kunena (including the latest version) which I can't find any reference to anywhere else on this forum (or elsewhere on the net). I'm not sure if this is the correct place to report it, but couldn't find anywhere more obvious, so apologies if this is the wrong place.

To reproduce:
Set the forum config to the display usernames instead of realnames (Forum Configuration > Users > Display User Name -> Yes) then go to the forum and click the "Quote" button on any post. The name quoted is the user's realname, not the username as expected.

This creates the confusing scenario where you are quoting "UserXYZ" as "John Smith wrote:".

There is a very straightforward fix to this.

site/funcs/post.php:

Change line:
Code:
$this->message_text .= "[quote=\"{$message->name}\" post={$message->id}]" . $mestext . "[/quote]";

To:
Code:
$this->message_text .= "[quote=\"" . ($this->config->username ? KunenaFactory::getUser ( $message->userid )->username : $message->name) . "\" post={$message->id}]" . $mestext . "[/quote]";

This is line 265 in the latest version of the code.

Could this be raised as a bug internally so that we don't have to remember to re-fix it at each upgrade.

Hope this helps someone.

MattLG
OpenGlobal
Last edit: 14 years 7 months ago by openglobal.

Please Log in or Create an account to join the conversation.

More
14 years 7 months ago #108019 by 810
Replied by 810 on topic Re: Bug (and fix): Quoting always shows realname, not username
Hi, i don't have this issue.

You must make a new topic then the name is good again. so if you change the setting, all new messages are changed. not the old ones.

regards 810

Please Log in or Create an account to join the conversation.

More
14 years 7 months ago #108022 by openglobal
Replied by openglobal on topic Re: Bug (and fix): Quoting always shows realname, not username
Oh I see.

That doesn't seem like the right way to work to me. Shouldn't the quoting depend on the setting at the time of the quote, not the time of the original post?

MattLG
OpenGlobal

Please Log in or Create an account to join the conversation.

Time to create page: 0.269 seconds