Kunena 7.0.6 & Kunena 6.4.12 – Security Updates Released

The Kunena team has announce the arrival of Kunena 7.0.6 [K 7.0.6] in stable which is now available for download as a native Joomla extension for J! 5.4.x/6.0.x. This version addresses most of the issues that were discovered in K 6.2 / K 6.3 / K 6.4 and issues discovered during the last development stages of K 7.0.

The Kunena team is also pleased to announce the twelfth version of Kunena 6.4, a native Joomla extension for Joomla! 5.0, 5.1, 5.2, 5.3, 5.4 and 6.0.

Topics that are moved into this category are generally considered to be closed. Users may want to add additional information but these topics should not be resurrected in order to discuss new problems or unrelated matters.

Question move thread facility times out even at 160 seconds

hareslade
Topic Author
Offline
Junior Member

16 years 10 months ago #26360 by hareslade

move thread facility times out even at 160 seconds was created by hareslade

Hi
I have 1.08 running, but php code is identocal in v 1.5.4 I think

Moving a thread between forums times out, even at 160 seconds timeout for php setting. Our forum is fairly large but as I don't know exactly what the coding does, can someone supply a quick fix so the script doesn't time out, but the move process is intact?

The move does actually take place, usually, but the process isn't shown on the page because it times out. That is, the forum isn't redisplayed.

Code is in class.kunena.php. at line 429 onwards in v 1.5.4

Code:

while ($messages_iter->loadNextObject($l)) {
        	$i++;
            //if($i==100) { die(); }
            $cat_l = $l->catid;

            while ($cat_l) {
//xx
                if ($l->parent == 0) {
                    $ctg[$cat_l]->numTopics++;
                    }
                else {
                    $ctg[$cat_l]->numPosts++;
                    }

                $ctg[$cat_l]->id_last_msg = $l->id;
                $ctg[$cat_l]->time_last_msg = $l->time;
                $cat_l = $ctg[$cat_l]->parent;
                }
            }

I really would appreciate a fix, our moderators can't move posts properly! Usually it times out listing the line after my //xx above. The loop is taking huge amounts of php processing time!

Interesting theres already a kunena commented out 'die' in the code, what happens if I invoke that?

incidentally we have a dedicated server so its not short of php processing power.

Thanks

Please Log in or Create an account to join the conversation.

hareslade
Topic Author
Offline
Junior Member

16 years 9 months ago #26443 by hareslade

Replied by hareslade on topic Re:move thread facility times out even at 160 seconds

Seasoned developers I'm not sure ......

If one removes the inner 'while' from the code, the move works perfectly.

I traced the prob to the fact that $ cat_1 appears to be the forum i.d, you don't need to have an inner loop as in my case it was 2, followed by an infinite number of 1's -- in other words the inner while loop is redundant,

Check before doing the mod, forum posts count for each forum is 0 (zero), the entries are not being loaded with the number of posts etc.

after doing the mod, on our forum at least, it now shows correct counts.
And a move thread across forums, function, takes about a second rather than for ever.

Code:

while ($messages_iter->loadNextObject($l)) {
         $i++;
            //if($i==100) { die(); }
            $cat_l = $l->catid;

     // ******REMOVE THIS LINE      while ($cat_l) {
//xx
                if ($l->parent == 0) {
                    $ctg[$cat_l]->numTopics++;
                    }
                else {
                    $ctg[$cat_l]->numPosts++;
                    }

                $ctg[$cat_l]->id_last_msg = $l->id;
                $ctg[$cat_l]->time_last_msg = $l->time;
                $cat_l = $ctg[$cat_l]->parent;
                }
       // ******REMOVE THIS LINE     } 

this is an intuitive fix, let me know if it wasn't right :woohoo:

paul

Please Log in or Create an account to join the conversation.

hareslade
Topic Author
Offline
Junior Member

16 years 9 months ago #26621 by hareslade

Replied by hareslade on topic Re:move thread facility times out even at 160 seconds

Hi
I also notice a locked thread which relates to this thread,
www.kunena.com/index.php?option=com_kune...4555&catid=139#24555

The timout on his thread i reckon is due to the same problem, the function reCountBoards timing out in a never ending loop.

I discovered from that thread, that its the 'recount category stats' that updates the front end's category forum post and topic counts display manually, whenever you want to do it.

would be nice to have some comments from the kunena programmers...

Please Log in or Create an account to join the conversation.